github-actions[bot] commented on code in PR #30133:
URL: https://github.com/apache/doris/pull/30133#discussion_r1465907148


##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -223,6 +243,131 @@ Status ProcessHashTableProbe<JoinOpType, 
Parent>::do_process(HashTableType& hash
     return Status::OK();
 }
 
+template <int JoinOpType, typename Parent>
+template <bool with_other_conjuncts>
+Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(

Review Comment:
   warning: function 'do_mark_join_conjuncts' has cognitive complexity of 55 
(threshold 50) [readability-function-cognitive-complexity]
   ```cpp
   Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(
                                                     ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:265:** +1, including 
nesting penalty of 0, nesting level increased to 1
   ```cpp
       if (_parent->_mark_join_conjuncts.empty()) {
       ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:277:** +2, including 
nesting penalty of 1, nesting level increased to 2
   ```cpp
           for (size_t i = 0; i != row_count; ++i) {
           ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:279:** +3, including 
nesting penalty of 2, nesting level increased to 3
   ```cpp
               if constexpr (is_null_aware_join) {
               ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:280:** +4, including 
nesting penalty of 3, nesting level increased to 4
   ```cpp
                   if constexpr (with_other_conjuncts) {
                   ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:283:** +1, nesting 
level increased to 4
   ```cpp
                   } else {
                     ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:284:** +5, including 
nesting penalty of 4, nesting level increased to 5
   ```cpp
                       if (filter_data[i]) {
                       ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:287:** +1, nesting 
level increased to 5
   ```cpp
                       } else if (_build_indexs[i] == 0) {
                              ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:290:** +1, nesting 
level increased to 5
   ```cpp
                       } else if (_build_indexs[i] == hash_table_bucket_size) {
                              ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:296:** +2, including 
nesting penalty of 1, nesting level increased to 2
   ```cpp
           if constexpr (!is_null_aware_join) {
           ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:299:** +1, nesting 
level increased to 1
   ```cpp
       } else {
         ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:300:** +2, including 
nesting penalty of 1, nesting level increased to 2
   ```cpp
           
RETURN_IF_ERROR(VExprContext::execute_conjuncts(_parent->_mark_join_conjuncts, 
output_block,
           ^
   ```
   **be/src/common/status.h:540:** expanded from macro 'RETURN_IF_ERROR'
   ```cpp
       do {                                \
       ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:300:** +3, including 
nesting penalty of 2, nesting level increased to 3
   ```cpp
           
RETURN_IF_ERROR(VExprContext::execute_conjuncts(_parent->_mark_join_conjuncts, 
output_block,
           ^
   ```
   **be/src/common/status.h:542:** expanded from macro 'RETURN_IF_ERROR'
   ```cpp
           if (UNLIKELY(!_status_.ok())) { \
           ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:307:** +1, including 
nesting penalty of 0, nesting level increased to 1
   ```cpp
       if constexpr (with_other_conjuncts) {
       ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:311:** +2, including 
nesting penalty of 1, nesting level increased to 2
   ```cpp
               
RETURN_IF_ERROR(VExprContext::execute_conjuncts(_parent->_other_join_conjuncts, 
nullptr,
               ^
   ```
   **be/src/common/status.h:540:** expanded from macro 'RETURN_IF_ERROR'
   ```cpp
       do {                                \
       ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:311:** +3, including 
nesting penalty of 2, nesting level increased to 3
   ```cpp
               
RETURN_IF_ERROR(VExprContext::execute_conjuncts(_parent->_other_join_conjuncts, 
nullptr,
               ^
   ```
   **be/src/common/status.h:542:** expanded from macro 'RETURN_IF_ERROR'
   ```cpp
           if (UNLIKELY(!_status_.ok())) { \
           ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:317:** +2, including 
nesting penalty of 1, nesting level increased to 2
   ```cpp
           for (size_t i = 0; i != filter.size(); ++i) {
           ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:336:** +1
   ```cpp
               *_has_null_in_build_side && is_null_aware_join && 
!with_other_conjuncts;
                                                              ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:337:** +1, including 
nesting penalty of 0, nesting level increased to 1
   ```cpp
       for (size_t i = 0; i != row_count; ++i) {
       ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:339:** +2, including 
nesting penalty of 1, nesting level increased to 2
   ```cpp
           if (_build_indexs[i] == 0) {
           ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:341:** +3, including 
nesting penalty of 2, nesting level increased to 3
   ```cpp
               if (not_matched_before) {
               ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:343:** +1
   ```cpp
                   mark_null_map[i] = has_null_mark_value || 
should_be_null_if_build_side_has_null;
                                                          ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:346:** +1, nesting 
level increased to 2
   ```cpp
           } else {
             ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:347:** +3, including 
nesting penalty of 2, nesting level increased to 3
   ```cpp
               if (mark_null_map[i]) { // is null
               ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:349:** +1, nesting 
level increased to 3
   ```cpp
               } else {
                 ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:350:** +4, including 
nesting penalty of 3, nesting level increased to 4
   ```cpp
                   if (mark_filter_data[i] && not_matched_before) {
                   ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:350:** +1
   ```cpp
                   if (mark_filter_data[i] && not_matched_before) {
                                           ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:358:** +1, including 
nesting penalty of 0, nesting level increased to 1
   ```cpp
       if constexpr (is_anti_join) {
       ^
   ```
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:360:** +2, including 
nesting penalty of 1, nesting level increased to 2
   ```cpp
           for (size_t i = 0; i != row_count; ++i) {
           ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to