AshinGau commented on code in PR #30075:
URL: https://github.com/apache/doris/pull/30075#discussion_r1464424649
##########
be/src/vec/exec/format/parquet/parquet_pred_cmp.h:
##########
@@ -240,6 +240,13 @@ class ParquetPredicate {
std::is_same_v<CppType,
DateV2Value<DateV2ValueType>>) {
min_value.from_unixtime(min_date_value * 24 * 60 * 60,
ctz);
max_value.from_unixtime(max_date_value * 24 * 60 * 60,
ctz);
+
+ // as VecDateTimeValue can not compare date and datetime,
so need
+ // cast to date here
+ if constexpr (std::is_same_v<CppType, VecDateTimeValue>) {
Review Comment:
1. `date` is deprecated, and FE will always generated `datev2` currently, so
how does `VecDateTimeValue `(for `date`) reach here?
2. `VecDateTimeValue ` has overload all compare operators, and doesn't
distinguish `TIME_TIME` and `TIME_DATE` in `VecDateTimeValue`？ So even if the
data type is `VecDateTimeValue`, it comes from `max_date_value * 24 * 60 * 60`,
which the same as `TIME_DATE` in `VecDateTimeValue`.
Any way, this is indeed a mistake, but neither will there be nor will there
be any correctness issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
