morningman commented on code in PR #30292:
URL: https://github.com/apache/doris/pull/30292#discussion_r1464201136
##########
be/src/util/s3_util.cpp:
##########
@@ -135,7 +135,7 @@ bool S3ClientFactory::is_s3_conf_valid(const
std::map<std::string, std::string>&
}
bool S3ClientFactory::is_s3_conf_valid(const S3Conf& s3_conf) {
- return !s3_conf.ak.empty() && !s3_conf.sk.empty() &&
!s3_conf.endpoint.empty();
+ return !s3_conf.endpoint.empty();
Review Comment:
Why only endpoint is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
