Nitin-Kashyap commented on PR #30189: URL: https://github.com/apache/doris/pull/30189#issuecomment-1905799606
> Hello @Nitin-Kashyap , regarding this issue, I think we should not add additional JDBC default parameters in HMSExternalCatalog to provide JdbcClient initialization. This will make the code bloated. We only need to simply specify the default values of the parameters in JdbcConfig, like This PR: #30262. because for The connection pool on the FE side will not bear excessive tasks, so it will not cause any problems. Of course, we will rearrange the parameters of the connection pool later to make it more reasonable. @zy-kkk : Agreed, however there should still exist some validation when specified `"hive.metastore.type" = "jdbc" ` I'm happy to contribute that as part of this PR. Please suggest which parameters should only be allowed in `type=hms`; I shall update this PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
