github-actions[bot] commented on code in PR #30279:
URL: https://github.com/apache/doris/pull/30279#discussion_r1463082746
##########
be/src/runtime/task_group/task_group_manager.cpp:
##########
@@ -266,7 +270,37 @@ void
TaskGroupManager::delete_task_group_by_ids(std::set<uint64_t> used_wg_id) {
}
}
}
- LOG(INFO) << "finish clear unused cgroup path";
+ int64_t time_cost_ms = MonotonicMillis() - begin_time;
+ LOG(INFO) << "finish clear unused task group, time cost: " << time_cost_ms
+ << "ms, deleted group size:" << deleted_tg_ids.size();
+}
+
+Status TaskGroupManager::add_query_to_group(uint64_t tg_id, TUniqueId query_id,
Review Comment:
warning: method 'add_query_to_group' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/task_group/task_group_manager.h:71:
```diff
- Status add_query_to_group(uint64_t tg_id, TUniqueId query_id,
TaskGroupPtr* tg_ptr);
+ static Status add_query_to_group(uint64_t tg_id, TUniqueId query_id,
TaskGroupPtr* tg_ptr);
```
##########
be/src/runtime/task_group/task_group.h:
##########
@@ -141,6 +141,16 @@ class TaskGroup : public
std::enable_shared_from_this<TaskGroup> {
return _memory_limit > 0;
}
+ void add_query(TUniqueId query_id) { _query_id_set.insert(query_id); }
+
+ void remove_query(TUniqueId query_id) { _query_id_set.erase(query_id); }
+
+ void shutdown() { _is_shutdown = true; }
+
+ int query_num() { return _query_id_set.size(); }
+
+ bool is_shutdown() { return _is_shutdown; }
Review Comment:
warning: method 'is_shutdown' can be made const
[readability-make-member-function-const]
```suggestion
bool is_shutdown() const { return _is_shutdown; }
```
##########
be/src/runtime/task_group/task_group_manager.cpp:
##########
@@ -266,7 +270,37 @@
}
}
}
- LOG(INFO) << "finish clear unused cgroup path";
+ int64_t time_cost_ms = MonotonicMillis() - begin_time;
+ LOG(INFO) << "finish clear unused task group, time cost: " << time_cost_ms
+ << "ms, deleted group size:" << deleted_tg_ids.size();
+}
+
+Status TaskGroupManager::add_query_to_group(uint64_t tg_id, TUniqueId query_id,
+ TaskGroupPtr* tg_ptr) {
+ std::lock_guard<std::shared_mutex> write_lock(_group_mutex);
+ auto tg_iter = _task_groups.find(tg_id);
+ if (tg_iter != _task_groups.end()) {
+ if (tg_iter->second->is_shutdown()) {
+ return Status::InternalError<false>("workload group {} is
shutdown.", tg_id);
+ }
+ tg_iter->second->add_query(query_id);
+ *tg_ptr = tg_iter->second;
+ return Status::OK();
+ } else {
+ return Status::InternalError<false>("can not find workload group {}.",
tg_id);
+ }
+}
+
+void TaskGroupManager::remove_query_from_group(uint64_t tg_id, TUniqueId
query_id) {
Review Comment:
warning: method 'remove_query_from_group' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/task_group/task_group_manager.h:73:
```diff
- void remove_query_from_group(uint64_t tg_id, TUniqueId query_id);
+ static void remove_query_from_group(uint64_t tg_id, TUniqueId
query_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
