zclllyybb commented on code in PR #30260:
URL: https://github.com/apache/doris/pull/30260#discussion_r1462936842
##########
be/src/vec/functions/function_java_udf.h:
##########
@@ -89,9 +89,12 @@ class JavaFunctionCall : public IFunctionBase {
PreparedFunctionPtr prepare(FunctionContext* context, const Block&
sample_block,
const ColumnNumbers& arguments, size_t result)
const override {
return std::make_shared<JavaUdfPreparedFunction>(
- std::bind<Status>(&JavaFunctionCall::execute_impl, this,
std::placeholders::_1,
- std::placeholders::_2, std::placeholders::_3,
- std::placeholders::_4,
std::placeholders::_5),
+ [this](auto&& PH1, auto&& PH2, auto&& PH3, auto&& PH4, auto&&
PH5) {
Review Comment:
For most situations, we can replace `auto&&` suggested by clang-tidy with
concrete type. there's no need to use template here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
