github-actions[bot] commented on code in PR #30254:
URL: https://github.com/apache/doris/pull/30254#discussion_r1462691485
##########
be/src/runtime/load_stream.cpp:
##########
@@ -70,7 +70,8 @@ inline std::ostream& operator<<(std::ostream& ostr, const
TabletStream& tablet_s
return ostr;
}
-Status TabletStream::init(OlapTableSchemaParam* schema, int64_t index_id,
int64_t partition_id) {
+Status TabletStream::init(std::shared_ptr<OlapTableSchemaParam> schema,
int64_t index_id,
Review Comment:
warning: method 'init' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/load_stream.h:49:
```diff
- Status init(std::shared_ptr<OlapTableSchemaParam> schema, int64_t
index_id, int64_t partition_id);
+ static Status init(std::shared_ptr<OlapTableSchemaParam> schema,
int64_t index_id, int64_t partition_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
