github-actions[bot] commented on code in PR #30133:
URL: https://github.com/apache/doris/pull/30133#discussion_r1460710039


##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -219,6 +225,100 @@ Status ProcessHashTableProbe<JoinOpType, 
Parent>::do_process(HashTableType& hash
     return Status::OK();
 }
 
+template <int JoinOpType, typename Parent>
+template <bool with_other_conjuncts>
+Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(

Review Comment:
   warning: function 'do_mark_join_conjuncts' exceeds recommended 
size/complexity thresholds [readability-function-size]
   ```cpp
   Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(
                                                     ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/vec/exec/join/process_hash_table_probe_impl.h:229:** 89 lines 
including whitespace and comments (threshold 80)
   ```cpp
   Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(
                                                     ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to