github-actions[bot] commented on code in PR #30133:
URL: https://github.com/apache/doris/pull/30133#discussion_r1458519827
##########
be/src/vec/exec/join/process_hash_table_probe.h:
##########
@@ -70,6 +70,9 @@ struct ProcessHashTableProbe {
Status do_other_join_conjuncts(Block* output_block, bool is_mark_join,
std::vector<uint8_t>& visited, bool
has_null_in_build_side);
+ template <bool with_other_conjuncts>
+ Status do_mark_join_conjuncts(Block* output_block, const size_t
hash_table_bucket_size);
Review Comment:
warning: parameter 'hash_table_bucket_size' is const-qualified in the
function declaration; const-qualification of parameters only has an effect in
function definitions [readability-avoid-const-params-in-decls]
```suggestion
Status do_mark_join_conjuncts(Block* output_block, size_t
hash_table_bucket_size);
```
##########
be/src/vec/exec/join/null_aware_left_semi_join_impl.cpp:
##########
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <gen_cpp/PlanNodes_types.h>
Review Comment:
warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/PlanNodes_types.h>
^
```
##########
be/src/vec/exprs/vexpr_context.cpp:
##########
@@ -233,6 +233,49 @@ Status VExprContext::execute_conjuncts(const
VExprContextSPtrs& ctxs,
return Status::OK();
}
+Status VExprContext::execute_conjuncts(const VExprContextSPtrs& conjuncts,
Block* block,
Review Comment:
warning: method 'execute_conjuncts' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status VExprContext::execute_conjuncts(const VExprContextSPtrs&
conjuncts, Block* block,
```
##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -219,6 +224,96 @@ Status ProcessHashTableProbe<JoinOpType,
Parent>::do_process(HashTableType& hash
return Status::OK();
}
+template <int JoinOpType, typename Parent>
+template <bool with_other_conjuncts>
+Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(
Review Comment:
warning: function 'do_mark_join_conjuncts' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/join/process_hash_table_probe_impl.h:228:** 85 lines
including whitespace and comments (threshold 80)
```cpp
Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
