platoneko commented on code in PR #30128:
URL: https://github.com/apache/doris/pull/30128#discussion_r1458424456
##########
be/src/olap/base_tablet.h:
##########
@@ -88,7 +89,34 @@ class BaseTablet {
Status capture_rs_readers_unlocked(const std::vector<Version>&
version_path,
std::vector<RowSetSplits>* rs_splits)
const;
+ // _rs_version_map and _stale_rs_version_map should be protected by
_meta_lock
+ // The caller must call hold _meta_lock when call this two function.
+ RowsetSharedPtr get_rowset_by_version(const Version& version, bool
find_is_stale = false) const;
+ RowsetSharedPtr get_stale_rowset_by_version(const Version& version) const;
+ RowsetSharedPtr get_rowset_with_max_version() const;
+
+ Status all_rs_id(int64_t max_version, RowsetIdUnorderedSet* rowset_ids)
const;
+
+ // Given spec_version, find a continuous version path and store it in
version_path.
+ // If quiet is true, then only "does this path exist" is returned.
+ // If skip_missing_version is true, return ok even there are missing
versions.
+ Status capture_consistent_versions_unlocked(const Version& spec_version,
+ std::vector<Version>*
version_path,
+ bool skip_missing_version,
bool quiet) const;
+
+ // operation for clone
+ void calc_missed_versions(int64_t spec_version, std::vector<Version>*
missed_versions);
+ void calc_missed_versions_unlocked(int64_t spec_version,
+ std::vector<Version>* missed_versions)
const;
+
+ size_t num_rows();
+ int version_count() const;
+ uint64_t segment_count() const;
+ Version max_version() const;
Review Comment:
`CloudTablet` 有一些已经聚合的状态值可以直接用在这
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
