morningman commented on a change in pull request #6373: URL: https://github.com/apache/incubator-doris/pull/6373#discussion_r682664777
########## File path: extension/DataX/doriswriter/src/main/java/com/alibaba/datax/plugin/writer/doriswriter/DorisCsvCodec.java ########## @@ -0,0 +1,53 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + */ +package com.alibaba.datax.plugin.writer.doriswriter; + +import com.alibaba.datax.common.element.Record; +import com.alibaba.fastjson.JSON; + +import java.util.*; + +// Convert DataX data to csv +public class DorisCsvCodec extends DorisCodec { + private static TimeZone timeZoner = TimeZone.getTimeZone(timeZone); + + private String columnSeparator; + + public DorisCsvCodec(final List<String> fieldNames, String columnSeparator) { + super(fieldNames); + this.columnSeparator = columnSeparator; + } + + @Override + public String serialize(final Record row) { + if (null == this.fieldNames) { + return ""; + } + List<String> list = new ArrayList<>(); + + for (int i = 0; i < this.fieldNames.size(); i++) { + Object value = this.convertColumn(row.getColumn(i)); + list.add(value != null ? value.toString() : ""); Review comment: for null value, it should be `"\N"` ########## File path: extension/DataX/doriswriter/src/main/java/com/alibaba/datax/plugin/writer/doriswriter/Key.java ########## @@ -22,6 +22,8 @@ Licensed to the Apache Software Foundation (ASF) under one import com.alibaba.datax.common.exception.DataXException; import com.alibaba.datax.common.util.Configuration; import com.alibaba.datax.plugin.rdbms.util.DBUtilErrorCode; +import com.alibaba.fastjson.JSON; Review comment: unused imports? ########## File path: extension/DataX/doriswriter/doc/doriswriter.md ########## @@ -163,6 +163,18 @@ DorisWriter 通过Doris原生支持Stream load方式导入数据， DorisWriter - 描述：每批次数据包含多行，每行为 Json 格式，每行的的分隔符即为 lineDelimiter。 - 必选：否 - 默认值：`\n` + +* **format** + + - 描述：导入数据的格式, 可以使是json或者csv。 + - 必选：否 + - 默认值：`json` + +* **columnSeparator** + + - 描述：当导入的格式是csv时, 字段之间的分隔符。 + - 必选：否 + - 默认值：`\t` Review comment: There may be any character exist in user data, such as `\t` or `,`. So it is better to use a invisible multi-bytes separator as default column separator here, I recommend to use `\x0707` ########## File path: extension/DataX/doriswriter/src/main/java/com/alibaba/datax/plugin/writer/doriswriter/DorisCsvCodec.java ########## @@ -0,0 +1,53 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + */ +package com.alibaba.datax.plugin.writer.doriswriter; + +import com.alibaba.datax.common.element.Record; +import com.alibaba.fastjson.JSON; + +import java.util.*; + +// Convert DataX data to csv +public class DorisCsvCodec extends DorisCodec { + private static TimeZone timeZoner = TimeZone.getTimeZone(timeZone); + + private String columnSeparator; + + public DorisCsvCodec(final List<String> fieldNames, String columnSeparator) { + super(fieldNames); + this.columnSeparator = columnSeparator; + } + + @Override + public String serialize(final Record row) { + if (null == this.fieldNames) { + return ""; + } + List<String> list = new ArrayList<>(); + + for (int i = 0; i < this.fieldNames.size(); i++) { + Object value = this.convertColumn(row.getColumn(i)); + list.add(value != null ? value.toString() : ""); Review comment: Like this: `list.add(value != null ? value.toString() : "\\N");` ########## File path: extension/DataX/doriswriter/doc/doriswriter.md ########## @@ -163,6 +163,18 @@ DorisWriter 通过Doris原生支持Stream load方式导入数据， DorisWriter - 描述：每批次数据包含多行，每行为 Json 格式，每行的的分隔符即为 lineDelimiter。 - 必选：否 - 默认值：`\n` + +* **format** + + - 描述：导入数据的格式, 可以使是json或者csv。 + - 必选：否 + - 默认值：`json` + +* **columnSeparator** + + - 描述：当导入的格式是csv时, 字段之间的分隔符。 + - 必选：否 + - 默认值：`\t` Review comment: OK I see. So please modify the description to remind this risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
