yangzhg commented on a change in pull request #6365:
URL: https://github.com/apache/incubator-doris/pull/6365#discussion_r683063839
##########
File path: be/src/olap/cumulative_compaction_policy.cpp
##########
@@ -68,40 +68,55 @@ void
SizeBasedCumulativeCompactionPolicy::calculate_cumulative_point(
// calculate promotion size
auto base_rowset_meta = existing_rss.begin();
- // check base rowset first version must be zero
- CHECK((*base_rowset_meta)->start_version() == 0);
- int64_t promotion_size = 0;
- _calc_promotion_size(*base_rowset_meta, &promotion_size);
+ if (tablet->tablet_state() == TABLET_RUNNING) {
+ // check base rowset first version must be zero
+ // for tablet which state is not TABLET_RUNNING, there may not have
base version.
+ CHECK((*base_rowset_meta)->start_version() == 0);
Review comment:
move to next if block ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
