github-actions[bot] commented on code in PR #30052:
URL: https://github.com/apache/doris/pull/30052#discussion_r1455146994
##########
be/src/vec/data_types/serde/data_type_object_serde.cpp:
##########
@@ -57,6 +60,36 @@ Status DataTypeObjectSerDe::write_column_to_mysql(const
IColumn& column,
return Status::OK();
}
+void DataTypeObjectSerDe::write_one_cell_to_jsonb(const IColumn& column,
JsonbWriter& result,
+ Arena* mem_pool, int32_t
col_id,
+ int row_num) const {
+ const auto& variant = assert_cast<const ColumnObject&>(column);
+ if (!variant.is_finalized()) {
+ const_cast<ColumnObject&>(variant).finalize();
+ }
+ result.writeKey(col_id);
+ JsonbParser json_parser;
+ CHECK(variant.get_original_column() != nullptr);
+ // use original document
+ const auto& data_ref = variant.get_original_column()->get_data_at(row_num);
+ // encode as jsonb
+ bool succ = json_parser.parse(data_ref.data, data_ref.size);
+ // maybe more graceful, it is ok to check here since data could be parsed
+ CHECK(succ);
+ result.writeStartBinary();
+ result.writeBinary(json_parser.getWriter().getOutput()->getBuffer(),
+ json_parser.getWriter().getOutput()->getSize());
+ result.writeEndBinary();
+}
+
+void DataTypeObjectSerDe::read_one_cell_from_jsonb(IColumn& column, const
JsonbValue* arg) const {
+ auto& variant = assert_cast<ColumnObject&>(column);
+ Field field;
+ auto blob = static_cast<const JsonbBlobVal*>(arg);
Review Comment:
warning: 'auto blob' can be declared as 'const auto *blob'
[readability-qualified-auto]
```suggestion
const auto *blob = static_cast<const JsonbBlobVal*>(arg);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
