JackDrogon commented on code in PR #30021:
URL: https://github.com/apache/doris/pull/30021#discussion_r1453191932
##########
be/src/vec/sink/writer/vtablet_writer.h:
##########
@@ -562,6 +558,8 @@ class VTabletWriter final : public AsyncResultWriter {
Status _incremental_open_node_channel(const
std::vector<TOlapTablePartition>& partitions);
+ void _do_try_close(RuntimeState* state, Status exec_status);
Review Comment:
exec_status don't need to be passed by value
##########
be/src/vec/sink/async_writer_sink.h:
##########
@@ -113,7 +113,7 @@ class AsyncWriterSink : public DataSink {
return Status::OK();
}
- bool is_close_done() override { return !_writer->is_pending_finish(); }
+ bool is_pending_finish() override { return _writer->is_pending_finish(); }
Review Comment:
mark as const & nodiscard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
