github-actions[bot] commented on code in PR #29999: URL: https://github.com/apache/doris/pull/29999#discussion_r1453003900
########## be/src/runtime/runtime_query_statistics_mgr.cpp: ########## @@ -171,4 +172,12 @@ std::shared_ptr<QueryStatistics> RuntimeQueryStatiticsMgr::get_runtime_query_sta return qs_ptr; } +void RuntimeQueryStatiticsMgr::set_workload_group_id(std::string query_id, int64_t wg_id) { Review Comment: warning: method 'set_workload_group_id' can be made static [readability-convert-member-functions-to-static] ```suggestion static void RuntimeQueryStatiticsMgr::set_workload_group_id(std::string query_id, int64_t wg_id) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org