yujun777 commented on code in PR #30001:
URL: https://github.com/apache/doris/pull/30001#discussion_r1452868426
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -1546,7 +1549,9 @@ public void addPartition(Database db, String tableName,
AddPartitionClause addPa
olapTable.getTimeSeriesCompactionTimeThresholdSeconds(),
olapTable.getTimeSeriesCompactionEmptyRowsetsThreshold(),
olapTable.storeRowColumn(),
- binlogConfig, dataProperty.isStorageMediumSpecified(),
null);
+ binlogConfig, dataProperty.isStorageMediumSpecified(),
null,
+ olapTable.getTTLSeconds());
+ afterCreatePartitions(olapTable.getId(), partitionIds, indexIds);
Review Comment:
代码里有创建多个分区的， 先在创建它们之前把所有partition先prepare，
在建完partition之后，在对所有分区再commit一次。如果要改，需要把InternalCatalog里重构一下代码，把多个分区的代码在扣出成一个函数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
