stdpain commented on a change in pull request #6329:
URL: https://github.com/apache/incubator-doris/pull/6329#discussion_r679799775
##########
File path: be/CMakeLists.txt
##########
@@ -704,3 +704,8 @@ install(FILES
${BASE_DIR}/../conf/odbcinst.ini
DESTINATION ${OUTPUT_DIR}/conf)
+
+get_property(dirs DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY
INCLUDE_DIRECTORIES)
Review comment:
may be we should remove cmake log ?
##########
File path: be/src/exprs/aggregate_functions.cpp
##########
@@ -1925,8 +1939,7 @@ DoubleVal
AggregateFunctions::knuth_var_pop_finalize(FunctionContext* ctx,
}
DecimalV2Val
AggregateFunctions::decimalv2_knuth_var_pop_finalize(FunctionContext* ctx,
- const
StringVal& state_sv) {
- DCHECK(!state_sv.is_null);
+ const StringVal& state_sv) {
Review comment:
need a code format here?
##########
File path: build.sh
##########
@@ -84,7 +92,7 @@ fi
eval set -- "$OPTS"
-PARALLEL=$[$(nproc)/4+1]
+PARALLEL=$[$(nproc)+1]
Review comment:
set PARALLEL= $[$(nproc)/4+1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
