morningman commented on code in PR #29561:
URL: https://github.com/apache/doris/pull/29561#discussion_r1449936697
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowBuildIndexStmt.java:
##########
@@ -136,7 +136,7 @@ public void analyze(Analyzer analyzer) throws
AnalysisException, UserException {
private void analyzeSubPredicate(Expr subExpr) throws AnalysisException {
if (subExpr == null) {
Review Comment:
I think we can simply remove the `if` in line 99.
And not change here.
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowBuildIndexStmt.java:
##########
@@ -136,7 +136,7 @@ public void analyze(Analyzer analyzer) throws
AnalysisException, UserException {
private void analyzeSubPredicate(Expr subExpr) throws AnalysisException {
if (subExpr == null) {
Review Comment:
BTW, could you please also modify the comment in line 44, that is a typo.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
