zhangbutao commented on code in PR #27784: URL: https://github.com/apache/doris/pull/27784#discussion_r1448291231
########## be/src/util/hash_util.hpp: ########## @@ -133,13 +133,21 @@ class HashUtil { // refer to https://github.com/apache/commons-codec/blob/master/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java static const uint32_t MURMUR3_32_SEED = 104729; + // refer https://github.com/apache/spark/blob/v3.5.0/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala#L615 + static const uint32_t SPARK_MURMUR_32_SEED = 42; Review Comment: Do you consider the compatibility with hive hash? Ref https://issues.apache.org/jira/browse/SPARK-17495, IMO, Hive3 use a different hash implementation from Spark's Murmur3Hash. If the bucketed table is created by HiveServer2, can we get the correct results with this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org