amorynan commented on code in PR #29599:
URL: https://github.com/apache/doris/pull/29599#discussion_r1448243844


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/StructLiteral.java:
##########
@@ -89,18 +120,29 @@ public String toString() {
 
     @Override
     public String toSql() {
-        return "{" + 
fields.stream().map(Literal::toSql).collect(Collectors.joining(",")) + "}";
+        StringBuilder sb = new StringBuilder();

Review Comment:
   this func is same with legacyliteral toSqlImpl ? maybe legacyliteral impl is 
wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to