This is an automated email from the ASF dual-hosted git repository.
jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new defd4fbd07a [fix](Nereids): add def in test (#29796)
defd4fbd07a is described below
commit defd4fbd07aad8d14be9be2a508a0da79588dd4a
Author: jakevin <jakevin...@gmail.com>
AuthorDate: Thu Jan 11 00:04:24 2024 +0800
[fix](Nereids): add def in test (#29796)
missing `def` will cause variable is global, it's easily to cause
concurrent problem
---
.../suites/nereids_p0/create_table/test_ctas.groovy | 4 ++--
.../suites/nereids_p0/expression/case_when_to_if.groovy | 10 +++++-----
.../suites/nereids_p0/expression/topn_to_max.groovy | 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/regression-test/suites/nereids_p0/create_table/test_ctas.groovy
b/regression-test/suites/nereids_p0/create_table/test_ctas.groovy
index dcbf41139b8..507bff03ea0 100644
--- a/regression-test/suites/nereids_p0/create_table/test_ctas.groovy
+++ b/regression-test/suites/nereids_p0/create_table/test_ctas.groovy
@@ -72,8 +72,8 @@ suite("nereids_test_ctas") {
) as select test_varchar, lpad(test_text,10,'0') as test_text,
test_datetime, test_default_timestamp from test_ctas;
"""
- res = sql """SHOW CREATE TABLE `test_ctas2`"""
- assertTrue(res.size() != 0)
+ def res1 = sql """SHOW CREATE TABLE `test_ctas2`"""
+ assertTrue(res1.size() != 0)
qt_select """select count(*) from test_ctas2"""
diff --git
a/regression-test/suites/nereids_p0/expression/case_when_to_if.groovy
b/regression-test/suites/nereids_p0/expression/case_when_to_if.groovy
index 8c41b8d1c67..c83ce27c017 100644
--- a/regression-test/suites/nereids_p0/expression/case_when_to_if.groovy
+++ b/regression-test/suites/nereids_p0/expression/case_when_to_if.groovy
@@ -30,7 +30,7 @@ suite("test_case_when_to_if") {
from test_case_when_to_if
group by k2;
'''
- res = sql '''
+ def res = sql '''
explain rewritten plan select k2,
sum(case when (k1=1) then 1 end) sum1
from test_case_when_to_if
@@ -45,13 +45,13 @@ suite("test_case_when_to_if") {
from test_case_when_to_if
group by k2;
'''
- res = sql '''
+ def res1 = sql '''
explain rewritten plan select k2,
sum(case when (k1=1) then 1 else null end) sum1
from test_case_when_to_if
group by k2;
'''
- assertTrue(res.toString().contains("if"))
+ assertTrue(res1.toString().contains("if"))
sql '''
select k2,
@@ -59,11 +59,11 @@ suite("test_case_when_to_if") {
from test_case_when_to_if
group by k2;
'''
- res = sql '''
+ def res2 = sql '''
explain rewritten plan select k2,
sum(case when (k1>0) then k1 else abs(k1) end) sum1
from test_case_when_to_if
group by k2;
'''
- assertTrue(res.toString().contains("if"))
+ assertTrue(res2.toString().contains("if"))
}
diff --git a/regression-test/suites/nereids_p0/expression/topn_to_max.groovy
b/regression-test/suites/nereids_p0/expression/topn_to_max.groovy
index 4ed378144fa..83fb9cc8492 100644
--- a/regression-test/suites/nereids_p0/expression/topn_to_max.groovy
+++ b/regression-test/suites/nereids_p0/expression/topn_to_max.groovy
@@ -41,9 +41,9 @@ suite("test_topn_to_max") {
select topn(k2, 1)
from test_topn_to_max;
'''
- res = sql '''
+ def res1 = sql '''
explain rewritten plan select topn(k2, 1)
from test_topn_to_max;
'''
- assertTrue(res.toString().contains("max"), res.toString() + " should
contain max")
+ assertTrue(res1.toString().contains("max"), res1.toString() + " should
contain max")
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
