yujun777 commented on code in PR #29818: URL: https://github.com/apache/doris/pull/29818#discussion_r1447360734
########## be/src/olap/storage_engine.cpp: ########## @@ -448,45 +449,85 @@ Status StorageEngine::set_cluster_id(int32_t cluster_id) { return Status::OK(); } +StorageEngine::Disk_remaining_level get_available_level(double disk_usage_percent) { + assert(disk_usage_percent >= 0 && disk_usage_percent <= 1); + if (disk_usage_percent < 0.7) { + return StorageEngine::Disk_remaining_level::LOW; + } else if (disk_usage_percent < 0.85) { + return StorageEngine::Disk_remaining_level::MID; + } else { + return StorageEngine::Disk_remaining_level::HIGH; + } + return StorageEngine::Disk_remaining_level::LOW; Review Comment: delete unreachable code ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org