github-actions[bot] commented on code in PR #29723:
URL: https://github.com/apache/doris/pull/29723#discussion_r1446861528
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:
##########
@@ -763,13 +775,87 @@ Status RowGroupReader::_build_pos_delete_filter(size_t
read_rows) {
return Status::OK();
}
+Status RowGroupReader::_build_equality_delete_filter(Block* block, const
size_t read_rows) {
Review Comment:
warning: method '_build_equality_delete_filter' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/exec/format/parquet/vparquet_group_reader.h:200:
```diff
- Status _build_equality_delete_filter(Block* block, const size_t
read_rows);
+ static Status _build_equality_delete_filter(Block* block, const size_t
read_rows);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
