github-actions[bot] commented on code in PR #29668:
URL: https://github.com/apache/doris/pull/29668#discussion_r1445987294
##########
be/src/olap/rowset/rowset_meta.cpp:
##########
@@ -40,16 +45,25 @@ bool RowsetMeta::init(const std::string& pb_rowset_meta) {
return true;
}
+bool RowsetMeta::init(const RowsetMeta* rowset_meta) {
Review Comment:
warning: method 'init' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/rowset_meta.h:41:
```diff
- bool init(const RowsetMeta* rowset_meta);
+ static bool init(const RowsetMeta* rowset_meta);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
