github-actions[bot] commented on code in PR #29717:
URL: https://github.com/apache/doris/pull/29717#discussion_r1445732221


##########
be/src/index-tools/index_tool.cpp:
##########
@@ -211,8 +222,15 @@
         std::string dir_str = p.parent_path().string();
         std::string file_str = p.filename().string();
         auto fs = doris::io::global_local_filesystem();
+        bool is_exists = false;
+        auto file_path = dir_str + "/" + file_str;

Review Comment:
   warning: 'auto file_path' can be declared as 'const auto *file_path' 
[readability-qualified-auto]
   
   ```suggestion
           const auto *file_path = dir_str + "/" + file_str;
   ```
   



##########
be/src/index-tools/index_tool.cpp:
##########
@@ -187,8 +187,15 @@ int main(int argc, char** argv) {
         std::string dir_str = p.parent_path().string();
         std::string file_str = p.filename().string();
         auto fs = doris::io::global_local_filesystem();
+        bool is_exists = false;
+        auto file_path = dir_str + "/" + file_str;

Review Comment:
   warning: 'auto file_path' can be declared as 'const auto *file_path' 
[readability-qualified-auto]
   
   ```suggestion
           const auto *file_path = dir_str + "/" + file_str;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to