github-actions[bot] commented on code in PR #29005:
URL: https://github.com/apache/doris/pull/29005#discussion_r1445608038
##########
be/src/olap/task/engine_clone_task.cpp:
##########
@@ -159,6 +159,13 @@ Status EngineCloneTask::execute() {
}
Status EngineCloneTask::_do_clone() {
Review Comment:
warning: function '_do_clone' has cognitive complexity of 58 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status EngineCloneTask::_do_clone() {
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/task/engine_clone_task.cpp:161:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("EngineCloneTask.finish.random", {
^
```
**be/src/util/debug_points.h:32:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) {
\
^
```
**be/src/olap/task/engine_clone_task.cpp:161:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("EngineCloneTask.finish.random", {
^
```
**be/src/util/debug_points.h:34:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) {
\
^
```
**be/src/olap/task/engine_clone_task.cpp:162:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (rand() % 100 < (100 * dp->param("percent", 0.5))) {
^
```
**be/src/olap/task/engine_clone_task.cpp:168:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("EngineCloneTask.wait_clone", {
^
```
**be/src/util/debug_points.h:32:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) {
\
^
```
**be/src/olap/task/engine_clone_task.cpp:168:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("EngineCloneTask.wait_clone", {
^
```
**be/src/util/debug_points.h:34:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) {
\
^
```
**be/src/olap/task/engine_clone_task.cpp:182:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (tablet && tablet->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/task/engine_clone_task.cpp:182:** +1
```cpp
if (tablet && tablet->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/task/engine_clone_task.cpp:187:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(StorageEngine::instance()->tablet_manager()->drop_tablet(
^
```
**be/src/common/status.h:526:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/task/engine_clone_task.cpp:187:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(StorageEngine::instance()->tablet_manager()->drop_tablet(
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/task/engine_clone_task.cpp:189:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if
(!StorageEngine::instance()->tablet_manager()->register_clone_tablet(
^
```
**be/src/olap/task/engine_clone_task.cpp:199:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (tablet != nullptr) {
^
```
**be/src/olap/task/engine_clone_task.cpp:201:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!migration_rlock.owns_lock()) {
^
```
**be/src/olap/task/engine_clone_task.cpp:205:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (tablet->replica_id() < _clone_req.replica_id) {
^
```
**be/src/olap/task/engine_clone_task.cpp:217:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (tablet->enable_unique_key_merge_on_write()) {
^
```
**be/src/olap/task/engine_clone_task.cpp:220:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (min_pending_ver - 1 < specified_version) {
^
```
**be/src/olap/task/engine_clone_task.cpp:231:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (missed_versions.empty()) {
^
```
**be/src/olap/task/engine_clone_task.cpp:247:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_make_and_download_snapshots(*(tablet->data_dir()),
local_data_path,
^
```
**be/src/common/status.h:526:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/task/engine_clone_task.cpp:247:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_make_and_download_snapshots(*(tablet->data_dir()),
local_data_path,
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/task/engine_clone_task.cpp:250:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_finish_clone(tablet.get(), local_data_path,
specified_version,
^
```
**be/src/common/status.h:526:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/task/engine_clone_task.cpp:250:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_finish_clone(tablet.get(), local_data_path,
specified_version,
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/task/engine_clone_task.cpp:252:** +1, nesting level increased
to 1
```cpp
} else {
^
```
**be/src/olap/task/engine_clone_task.cpp:261:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(StorageEngine::instance()->obtain_shard_path(
^
```
**be/src/common/status.h:526:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/task/engine_clone_task.cpp:261:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(StorageEngine::instance()->obtain_shard_path(
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/task/engine_clone_task.cpp:278:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR_(status,
^
```
**be/src/olap/task/engine_clone_task.cpp:131:** expanded from macro
'RETURN_IF_ERROR_'
```cpp
do { \
^
```
**be/src/olap/task/engine_clone_task.cpp:278:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR_(status,
^
```
**be/src/olap/task/engine_clone_task.cpp:133:** expanded from macro
'RETURN_IF_ERROR_'
```cpp
if (UNLIKELY(!status.ok())) { \
^
```
**be/src/olap/task/engine_clone_task.cpp:285:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR_(status, tablet_manager->load_tablet_from_dir(store,
_clone_req.tablet_id,
^
```
**be/src/olap/task/engine_clone_task.cpp:131:** expanded from macro
'RETURN_IF_ERROR_'
```cpp
do { \
^
```
**be/src/olap/task/engine_clone_task.cpp:285:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR_(status, tablet_manager->load_tablet_from_dir(store,
_clone_req.tablet_id,
^
```
**be/src/olap/task/engine_clone_task.cpp:133:** expanded from macro
'RETURN_IF_ERROR_'
```cpp
if (UNLIKELY(!status.ok())) { \
^
```
**be/src/olap/task/engine_clone_task.cpp:289:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!tablet) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
