morrySnow commented on code in PR #29609: URL: https://github.com/apache/doris/pull/29609#discussion_r1444240793
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/NonNullable.java: ########## @@ -39,4 +43,9 @@ public FunctionSignature customSignature() { return FunctionSignature.ret(dataType).args(dataType); } + @Override + public Expression withChildren(List<Expression> children) { + Preconditions.checkArgument(children.size() == 1); Review Comment: add check msg ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Nullable.java: ########## @@ -39,4 +43,9 @@ public FunctionSignature customSignature() { return FunctionSignature.ret(dataType).args(dataType); } + @Override + public Expression withChildren(List<Expression> children) { + Preconditions.checkArgument(children.size() == 1); Review Comment: add check msg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org