github-actions[bot] commented on code in PR #29646:
URL: https://github.com/apache/doris/pull/29646#discussion_r1444133238
##########
be/src/vec/columns/column_array.h:
##########
@@ -163,10 +163,8 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
//ColumnPtr index(const IColumn & indexes, size_t limit) const;
template <typename Type>
ColumnPtr index_impl(const PaddedPODArray<Type>& indexes, size_t limit)
const;
- [[noreturn]] int compare_at(size_t n, size_t m, const IColumn& rhs_,
- int nan_direction_hint) const override {
- LOG(FATAL) << "compare_at not implemented";
- }
+ int compare_at(size_t n, size_t m, const IColumn& rhs_, int
nan_direction_hint) const override;
Review Comment:
warning: function 'compare_at' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int compare_at(size_t n, size_t m, const IColumn& rhs_,
int nan_direction_hint) const override;
```
##########
be/src/vec/columns/column_map.h:
##########
@@ -124,10 +124,9 @@ class ColumnMap final : public COWHelper<IColumn,
ColumnMap> {
void get_extremes(Field& min, Field& max) const override {
LOG(FATAL) << "get_extremes not implemented";
};
- [[noreturn]] int compare_at(size_t n, size_t m, const IColumn& rhs_,
- int nan_direction_hint) const override {
- LOG(FATAL) << "compare_at not implemented";
- }
+
+ int compare_at(size_t n, size_t m, const IColumn& rhs_, int
nan_direction_hint) const override;
Review Comment:
warning: function 'compare_at' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int compare_at(size_t n, size_t m, const IColumn& rhs_,
int nan_direction_hint) const override;
```
##########
be/src/vec/columns/column_struct.h:
##########
@@ -156,11 +156,8 @@ class ColumnStruct final : public COWHelper<IColumn,
ColumnStruct> {
MutableColumns scatter(ColumnIndex num_columns, const Selector& selector)
const override;
// ColumnPtr index(const IColumn & indexes, size_t limit) const override;
- [[noreturn]] int compare_at(size_t n, size_t m, const IColumn& rhs_,
- int nan_direction_hint) const override {
- LOG(FATAL) << "compare_at not implemented";
- }
void get_extremes(Field& min, Field& max) const override;
+ int compare_at(size_t n, size_t m, const IColumn& rhs_, int
nan_direction_hint) const override;
Review Comment:
warning: function 'compare_at' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int compare_at(size_t n, size_t m, const IColumn& rhs_,
int nan_direction_hint) const override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
