morningman commented on a change in pull request #6196:
URL: https://github.com/apache/incubator-doris/pull/6196#discussion_r667009395
##########
File path: be/src/agent/task_worker_pool.cpp
##########
@@ -1150,6 +1150,9 @@ void
TaskWorkerPool::_report_disk_state_worker_thread_callback() {
disk.__set_disk_total_capacity(root_path_info.disk_capacity);
disk.__set_data_used_capacity(root_path_info.data_used_capacity);
disk.__set_disk_available_capacity(root_path_info.available);
+ std::filesystem::path trash_path(root_path_info.path +
TRASH_PREFIX);
+ disk.__set_trash_used_capacity(
Review comment:
Why not update the trash dir size in `DataDir::update_capacity()`, just
like `data_used_capacity`?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/util/DebugUtil.java
##########
@@ -27,7 +27,7 @@
import java.util.UUID;
public class DebugUtil {
- public static final DecimalFormat DECIMAL_FORMAT_SCALE_3 = new
DecimalFormat("#.000");
+ public static final DecimalFormat DECIMAL_FORMAT_SCALE_3 = new
DecimalFormat("0.000");
Review comment:
Why change this? Is it some thing wrong with origin `#.000`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
