xinyiZzz commented on code in PR #29588: URL: https://github.com/apache/doris/pull/29588#discussion_r1442708916
########## be/src/olap/lru_cache.cpp: ########## @@ -670,7 +674,7 @@ void ShardedLRUCache::update_cache_metrics() const { Cache::Handle* DummyLRUCache::insert(const CacheKey& key, void* value, size_t charge, void (*deleter)(const CacheKey& key, void* value), CachePriority priority, size_t bytes) { - size_t handle_size = sizeof(LRUHandle) - 1 + key.size(); + size_t handle_size = sizeof(LRUHandle); Review Comment: core是因为我改成 new LRUHandle,release的时候是 free handle,所以这里必须用malloc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org