morningman commented on code in PR #28890: URL: https://github.com/apache/doris/pull/28890#discussion_r1442659883
########## fe/fe-core/src/main/java/org/apache/doris/plugin/DialectConverterPlugin.java: ########## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.plugin; + +import org.apache.doris.analysis.StatementBase; +import org.apache.doris.nereids.parser.Dialect; +import org.apache.doris.qe.SessionVariable; + +import com.google.common.collect.ImmutableSet; + +import java.util.List; +import javax.annotation.Nullable; + +/** + * Sql dialect adapter interface. + */ +public interface DialectConverterPlugin { + + /** + * Set dialect set which this plugin can handle + */ + ImmutableSet<Dialect> acceptDialects(); + + /** + * Override this method if you want to convert sql before parse, returns null as default. + * */ + default @Nullable String convertSql(String originSql, SessionVariable sessionVariable) { + return null; Review Comment: how about: ```suggestion return originSql; ``` ########## fe/fe-core/src/main/java/org/apache/doris/nereids/parser/Dialect.java: ########## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.parser; + +import javax.annotation.Nullable; + +/** + * ParseDialect enum, maybe support other dialect. + */ +public enum Dialect { + /** + * Doris parser dialect + */ + DORIS("doris"), + /** + * Trino parser dialect + */ + TRINO("trino"), + /** + * Presto parser dialect + */ + PRESTO("presto"), + /** + * Spark sql parser dialect + */ + SPARK_SQL("spark_sql"), + /** + * Hive parser dialect + */ + HIVE("hive"), + /** + * Iceberg parser dialect + */ + ICEBERG("iceberg"), Review Comment: iceberg\paimon\hudi\dlf are not query engine, so they don't have sql dialect, remove them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
