eldenmoon commented on code in PR #29297:
URL: https://github.com/apache/doris/pull/29297#discussion_r1442600036
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -185,6 +185,27 @@ const char*
ColumnStruct::deserialize_and_insert_from_arena(const char* pos) {
return pos;
}
+int ColumnStruct::compare_at(size_t n, size_t m, const IColumn& rhs_,
+ int nan_direction_hint) const {
+ const ColumnStruct& rhs = assert_cast<const ColumnStruct&>(rhs_);
+
+ const size_t lhs_tuple_size = columns.size();
+ const size_t rhs_tuple_size = rhs.tuple_size();
+
+ if (rhs_tuple_size < lhs_tuple_size) {
Review Comment:
is it correct to compare tuple size first? why not compare element first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
