github-actions[bot] commented on code in PR #29581:
URL: https://github.com/apache/doris/pull/29581#discussion_r1442530182
##########
be/src/runtime/tablets_channel.h:
##########
@@ -109,6 +109,10 @@ class BaseTabletsChannel {
void refresh_profile();
+ size_t total_received_rows() { return _total_received_rows; }
+
+ size_t num_rows_filtered() { return _num_rows_filtered; }
Review Comment:
warning: method 'num_rows_filtered' can be made const
[readability-make-member-function-const]
```suggestion
size_t num_rows_filtered() const { return _num_rows_filtered; }
```
##########
be/src/runtime/tablets_channel.h:
##########
@@ -109,6 +109,10 @@ class BaseTabletsChannel {
void refresh_profile();
+ size_t total_received_rows() { return _total_received_rows; }
Review Comment:
warning: method 'total_received_rows' can be made const
[readability-make-member-function-const]
```suggestion
size_t total_received_rows() const { return _total_received_rows; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
