github-actions[bot] commented on code in PR #29403:
URL: https://github.com/apache/doris/pull/29403#discussion_r1441755535
##########
be/src/vec/exprs/vexpr.cpp:
##########
@@ -554,4 +554,12 @@ Status VExpr::check_constant(const Block& block,
ColumnNumbers arguments) const
return Status::OK();
}
+Status VExpr::get_result_from_const(vectorized::Block* block, const
std::string& expr_name,
Review Comment:
warning: method 'get_result_from_const' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status VExpr::get_result_from_const(vectorized::Block* block, const
std::string& expr_name,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
