xiaokang commented on code in PR #29537:
URL: https://github.com/apache/doris/pull/29537#discussion_r1441659633
##########
be/src/common/config.cpp:
##########
@@ -999,6 +999,7 @@ DEFINE_Validator(file_cache_min_file_segment_size, [](const
int64_t config) -> b
DEFINE_Bool(clear_file_cache, "false");
DEFINE_Bool(enable_file_cache_query_limit, "false");
DEFINE_mInt32(file_cache_wait_sec_after_fail, "0"); // // zero for no waiting
and retrying
+DEFINE_String(file_cache_queue_percentage, "[17,2,1,20]");
Review Comment:
suggest name file_cache_queue_percent
##########
be/src/common/config.cpp:
##########
@@ -999,6 +999,7 @@ DEFINE_Validator(file_cache_min_file_segment_size, [](const
int64_t config) -> b
DEFINE_Bool(clear_file_cache, "false");
DEFINE_Bool(enable_file_cache_query_limit, "false");
DEFINE_mInt32(file_cache_wait_sec_after_fail, "0"); // // zero for no waiting
and retrying
+DEFINE_String(file_cache_queue_percentage, "[17,2,1,20]");
Review Comment:
17 + 2 + 1 + 20 < 100
##########
be/src/common/config.cpp:
##########
@@ -999,6 +999,7 @@ DEFINE_Validator(file_cache_min_file_segment_size, [](const
int64_t config) -> b
DEFINE_Bool(clear_file_cache, "false");
DEFINE_Bool(enable_file_cache_query_limit, "false");
DEFINE_mInt32(file_cache_wait_sec_after_fail, "0"); // // zero for no waiting
and retrying
+DEFINE_String(file_cache_queue_percentage, "[17,2,1,20]");
Review Comment:
add doc for be config
##########
be/src/olap/options.cpp:
##########
@@ -244,18 +244,44 @@ Status parse_conf_cache_paths(const std::string&
config_path, std::vector<CacheP
return Status::OK();
}
-io::FileCacheSettings CachePath::init_settings() const {
+Status parse_conf_cache_queue_percentage(std::string percentage_config,
+ std::vector<size_t>& percentages) {
+ if (percentage_config.front() != '[' || percentage_config.back() != ']') {
+ return Status::InvalidArgument("wrong percentage format");
Review Comment:
add more info for valid format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
