yangzhg commented on a change in pull request #6168:
URL: https://github.com/apache/incubator-doris/pull/6168#discussion_r664303494



##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -681,6 +686,10 @@ OLAPStatus StorageEngine::_start_trash_sweep(double* 
usage) {
     return res;
 }
 
+OLAPStatus StorageEngine::start_trash_sweep() {

Review comment:
       why add this function

##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -681,6 +686,10 @@ OLAPStatus StorageEngine::_start_trash_sweep(double* 
usage) {
     return res;
 }
 
+OLAPStatus StorageEngine::start_trash_sweep() {

Review comment:
       since that function is not used by this pr, please remove this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to