JNSimba commented on code in PR #285:
URL: 
https://github.com/apache/doris-flink-connector/pull/285#discussion_r1440220361


##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/CdcTools.java:
##########
@@ -148,7 +148,7 @@ private static void syncDatabase(
 
     private static Map<String, String> getConfigMap(MultipleParameterTool 
params, String key) {
         if (!params.has(key)) {
-            return null;
+            return new HashMap<>();

Review Comment:
   Is there any problem with returning null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to