yiguolei commented on code in PR #29466:
URL: https://github.com/apache/doris/pull/29466#discussion_r1440184708
##########
be/src/vec/sink/writer/vtablet_writer.h:
##########
@@ -524,7 +524,7 @@ class VTabletWriter final : public AsyncResultWriter {
Status open(RuntimeState* state, RuntimeProfile* profile) override;
- Status try_close(RuntimeState* state, Status exec_status);
+ Status try_close(Status s = Status::OK()) override;
Review Comment:
在try close 里，可能会访问runtime state的比如is canncelled？ 或者对于导入来说还会commit txn
也需要从runtime state 里拿参数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
