seawinde commented on code in PR #29418:
URL: https://github.com/apache/doris/pull/29418#discussion_r1440155833
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewAggregateRule.java:
##########
@@ -60,15 +68,35 @@
*/
public abstract class AbstractMaterializedViewAggregateRule extends
AbstractMaterializedViewRule {
- protected static final Map<Expression, Expression>
- AGGREGATE_ROLL_UP_EQUIVALENT_FUNCTION_MAP = new HashMap<>();
+ // we only support roll up function which has only one argument currently
+ protected static final List<Pair<Expression, Expression>>
+ AGGREGATE_ROLL_UP_EQUIVALENT_FUNCTION_LIST = new ArrayList<>();
+ protected static final List<Expression> SUPPORTED_ROLL_UP_FUNCTIONS = new
ArrayList<>();
Review Comment:
yeah, you are right. fix it with `aggregateFunction instanceof CouldRollUp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
