mymeiyi commented on code in PR #28757:
URL: https://github.com/apache/doris/pull/28757#discussion_r1439126649
##########
be/src/olap/wal_manager.h:
##########
@@ -69,6 +69,14 @@ class WalManager {
void add_wal_column_index(int64_t wal_id, std::vector<size_t>&
column_index);
void erase_wal_column_index(int64_t wal_id);
Status get_wal_column_index(int64_t wal_id, std::vector<size_t>&
column_index);
+ Status add_wal_cv_map(int64_t wal_id, std::shared_ptr<std::mutex> lock,
+ std::shared_ptr<std::condition_variable> cv);
+ Status erase_wal_cv_map(int64_t wal_id);
+ Status get_lock_and_cv(int64_t wal_id, std::shared_ptr<std::mutex>& lock,
+ std::shared_ptr<std::condition_variable>& cv);
+ Status wait_relay_wal_finish(int64_t wal_id);
+ bool find_wal_path(int64_t wal_id);
+ Status notify(int64_t wal_id);
Review Comment:
`notify` is a bad name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
