wangbo commented on code in PR #29337:
URL: https://github.com/apache/doris/pull/29337#discussion_r1439125344
##########
be/src/runtime/workload_management/workload_action.cpp:
##########
@@ -29,7 +30,35 @@ void WorkloadActionCancelQuery::exec(WorkloadQueryInfo*
query_info) {
}
void WorkloadActionMoveQuery::exec(WorkloadQueryInfo* query_info) {
- LOG(INFO) << "[workload_schedule]move query action run group=" << _wg_name;
+ QueryContext* query_ctx_ptr = query_info->_query_ctx_share_ptr.get();
Review Comment:
queryctx是存成一个sharedptr到WorkloadQueryInfo里了，WorkloadQueryInfo的生命周期是本次调度策略跑完所有的查询才会结束。不过这么一说感觉也有问题，queryctx可能析构的会很晚。感觉可以在每个查询策略匹配完之后就析构WorkloadQueryInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
