py023 commented on code in PR #29285: URL: https://github.com/apache/doris/pull/29285#discussion_r1438450273
########## be/src/http/action/config_action.cpp: ########## @@ -118,7 +118,6 @@ void ConfigAction::handle_update_config(HttpRequest* req) { std::string status(s.ok() ? "OK" : "BAD"); rapidjson::Value result; result.SetObject(); - rapidjson::Value(key.c_str(), key.size(), results.GetAllocator()); Review Comment: No, IIUC it just creates an useless JSON value and drops it immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org