xinyiZzz commented on code in PR #28940:
URL: https://github.com/apache/doris/pull/28940#discussion_r1437793293
##########
be/src/olap/page_cache.h:
##########
@@ -177,20 +177,20 @@ class StoragePageCache {
Cache* _get_page_cache(segment_v2::PageTypePB page_type) {
switch (page_type) {
case segment_v2::DATA_PAGE: {
- if (_data_page_cache) {
- return _data_page_cache->get();
+ if (_data_page_cache->is_init()) {
Review Comment:
上面有个 is_available 方法检查了 nullptr，用于短路 page cache 的使用，而
_data_page_cache->get() 不会返回nullptr
已修改，把 is_available 和 is_init 都删了，不需要短路了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
