github-actions[bot] commented on code in PR #29180:
URL: https://github.com/apache/doris/pull/29180#discussion_r1437460327
##########
be/src/http/action/http_stream.cpp:
##########
@@ -403,4 +366,51 @@ void
HttpStreamAction::_save_stream_load_record(std::shared_ptr<StreamLoadContex
}
}
+Status HttpStreamAction::_handle_group_commit(HttpRequest* req,
Review Comment:
warning: method '_handle_group_commit' can be made static
[readability-convert-member-functions-to-static]
be/src/http/action/http_stream.h:51:
```diff
- Status _handle_group_commit(HttpRequest* http_req,
std::shared_ptr<StreamLoadContext> ctx);
+ static Status _handle_group_commit(HttpRequest* http_req,
std::shared_ptr<StreamLoadContext> ctx);
```
##########
be/src/http/action/stream_load.cpp:
##########
@@ -730,4 +692,51 @@ void
StreamLoadAction::_save_stream_load_record(std::shared_ptr<StreamLoadContex
}
}
+Status StreamLoadAction::_handle_group_commit(HttpRequest* req,
Review Comment:
warning: method '_handle_group_commit' can be made static
[readability-convert-member-functions-to-static]
be/src/http/action/stream_load.h:52:
```diff
- Status _handle_group_commit(HttpRequest* http_req,
std::shared_ptr<StreamLoadContext> ctx);
+ static Status _handle_group_commit(HttpRequest* http_req,
std::shared_ptr<StreamLoadContext> ctx);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
