JNSimba commented on code in PR #265:
URL:
https://github.com/apache/doris-flink-connector/pull/265#discussion_r1436696819
##########
flink-doris-connector/build.sh:
##########
@@ -160,7 +162,7 @@ FLINK_MAJOR_VERSION=0
echo_g " flink version: ${FLINK_VERSION}, major version:
${FLINK_MAJOR_VERSION}"
echo_g " build starting..."
-${MVN_BIN} clean package -Dflink.version=${FLINK_VERSION}
-Dflink.major.version=${FLINK_MAJOR_VERSION} "$@"
+${MVN_BIN} clean package -Dflink.version=${FLINK_VERSION}
-Dflink.major.version=${FLINK_MAJOR_VERSION}
-Dflink.python.id=${FLINK_PYTHON_ID} "$@"
Review Comment:
This also needs to be added to the configuration items of the pipeline.
##########
flink-doris-connector/build.sh:
##########
@@ -160,7 +162,7 @@ FLINK_MAJOR_VERSION=0
echo_g " flink version: ${FLINK_VERSION}, major version:
${FLINK_MAJOR_VERSION}"
echo_g " build starting..."
-${MVN_BIN} clean package -Dflink.version=${FLINK_VERSION}
-Dflink.major.version=${FLINK_MAJOR_VERSION} "$@"
+${MVN_BIN} clean package -Dflink.version=${FLINK_VERSION}
-Dflink.major.version=${FLINK_MAJOR_VERSION}
-Dflink.python.id=${FLINK_PYTHON_ID} "$@"
Review Comment:
This also needs to be added to the configuration items of the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
