morrySnow commented on code in PR #28913:
URL: https://github.com/apache/doris/pull/28913#discussion_r1435972038


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateLogicalSelectHint.java:
##########
@@ -85,7 +90,15 @@ private void setVar(SelectHintSetVar selectHint, 
StatementContext context) {
         SessionVariable sessionVariable = 
context.getConnectContext().getSessionVariable();
         // set temporary session value, and then revert value in the 'finally 
block' of StmtExecutor#execute
         sessionVariable.setIsSingleSetVar(true);
-        for (Entry<String, Optional<String>> kv : 
selectHint.getParameters().entrySet()) {
+        Map<String, Optional<String>> parameters = selectHint.getParameters();
+        StatementBase parsedStatement = context.getParsedStatement();
+        if (parsedStatement instanceof LogicalPlanAdapter) {
+            LogicalPlan logicalPlan = ((LogicalPlanAdapter) 
parsedStatement).getLogicalPlan();

Review Comment:
    should not impl here. please refer to 
`org.apache.doris.nereids.processor.pre.TurnOffPipelineForDml`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to