yangzhg commented on a change in pull request #5983:
URL: https://github.com/apache/incubator-doris/pull/5983#discussion_r647122518
##########
File path: be/src/olap/column_vector.cpp
##########
@@ -173,31 +186,31 @@ Status ArrayColumnVectorBatch::resize(size_t new_cap) {
if (capacity() < new_cap) {
RETURN_IF_ERROR(ColumnVectorBatch::resize(new_cap));
_data.resize(new_cap);
- _item_offsets.resize(new_cap + 1);
+ _offsets->resize(new_cap + 1);
}
return Status::OK();
}
-void ArrayColumnVectorBatch::put_item_ordinal(segment_v2::ordinal_t* ordinals,
size_t start_idx,
- size_t size) {
- size_t first_offset = _item_offsets[start_idx];
- segment_v2::ordinal_t first_ordinal = ordinals[0];
- size_t i = 0;
- while (++i < size) {
- _item_offsets[start_idx + i] = first_offset + (ordinals[i] -
first_ordinal);
+void ArrayColumnVectorBatch::change_sizes_to_offsets(size_t start_idx, size_t
size) {
Review comment:
get_offset maybe better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
