github-actions[bot] commented on code in PR #28788:
URL: https://github.com/apache/doris/pull/28788#discussion_r1435477599
##########
be/src/vec/core/column_with_type_and_name.cpp:
##########
@@ -87,4 +88,28 @@ void ColumnWithTypeAndName::to_pb_column_meta(PColumnMeta*
col_meta) const {
type->to_pb_column_meta(col_meta);
}
+ColumnWithTypeAndName ColumnWithTypeAndName::get_nested(bool
replace_null_data_to_default) const {
Review Comment:
warning: method 'get_nested' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/core/column_with_type_and_name.h:67:
```diff
- ColumnWithTypeAndName get_nested(bool replace_null_data_to_default =
false) const;
+ static ColumnWithTypeAndName get_nested(bool
replace_null_data_to_default = false) ;
```
```suggestion
ColumnWithTypeAndName ColumnWithTypeAndName::get_nested(bool
replace_null_data_to_default) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
