HappenLee commented on code in PR #28727:
URL: https://github.com/apache/doris/pull/28727#discussion_r1435426671
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -1329,11 +1317,15 @@ VScanNode::PushDownType
VScanNode::_should_push_down_in_predicate(VInPredicate*
Status VScanNode::_prepare_scanners(const int query_parallel_instance_num) {
std::list<VScannerSPtr> scanners;
RETURN_IF_ERROR(_init_scanners(&scanners));
Review Comment:
better change `init_scanner` function like `start_scanner`, call
`RETURN_IF_ERROR(_init_scanners(&_scanners))`
remove the useless std::list<VScannerSPtr> scanners;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
