mymeiyi commented on code in PR #27726:
URL: https://github.com/apache/doris/pull/27726#discussion_r1432189587
##########
be/src/vec/sink/group_commit_block_sink.h:
##########
@@ -75,6 +77,7 @@ class GroupCommitBlockSink : public DataSink {
std::vector<VOlapTablePartition*> _partitions;
Bitmap _filter_bitmap;
bool _has_filtered_rows = false;
+ std::mutex lock;
Review Comment:
is this lock unused?
##########
be/src/vec/sink/group_commit_block_sink.h:
##########
@@ -47,7 +47,9 @@ class GroupCommitBlockSink : public DataSink {
private:
Status _add_block(RuntimeState* state, std::shared_ptr<vectorized::Block>
block);
- Status _add_blocks();
+ Status _add_blocks(bool write_wal);
+ const string& _get_max_disk_usage_dir(
Review Comment:
is this function unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
